Skip to content

Update amrex submodule w/ bugfixes#1705

Merged
BenWibking merged 1 commit intodevelopmentfrom
BenWibking/update-amrex-feb26
Feb 26, 2026
Merged

Update amrex submodule w/ bugfixes#1705
BenWibking merged 1 commit intodevelopmentfrom
BenWibking/update-amrex-feb26

Conversation

@BenWibking
Copy link
Collaborator

Description

Updates AMReX to include some particle restart bug fixes. Not yet tested with Quokka.

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 25, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @BenWibking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the AMReX submodule to a newer version that includes critical bug fixes for particle restart functionalities. This ensures the project leverages the latest stability improvements from the AMReX framework, though integration testing with Quokka is still pending.

Highlights

  • AMReX Submodule Update: Updated the AMReX submodule to commit 1b174b21d5c3f861e80bfce97577c58765eeaebd from be8dfebe4beac85e027a121a178c97c02d258eb3, incorporating fixes for particle restart bugs.
Changelog
  • extern/amrex
    • Updated the AMReX submodule to a new commit hash.
Activity
  • The author provided a description for the pull request.
  • The author indicated no related issues.
  • The author confirmed reading the contributing guide.
  • The author noted that tests for new physics were not added.
  • The author noted that GPU tests were not triggered.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@BenWibking BenWibking changed the title update amrex for particle bugfixes update amrex submodule w/ bugfixes Feb 25, 2026
@dosubot dosubot bot added the particles label Feb 25, 2026
@BenWibking
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the AMReX submodule. The main concern is that this update is untested, which poses a significant risk of introducing regressions or breaking changes. A review comment has been added to highlight the need for thorough testing before merging.

@BenWibking BenWibking enabled auto-merge February 25, 2026 21:03
@BenWibking BenWibking changed the title update amrex submodule w/ bugfixes Update amrex submodule w/ bugfixes Feb 25, 2026
@BenWibking BenWibking added this pull request to the merge queue Feb 25, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2026
@BenWibking BenWibking added this pull request to the merge queue Feb 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2026
@BenWibking BenWibking added this pull request to the merge queue Feb 26, 2026
Merged via the queue into development with commit 7f8b834 Feb 26, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer particles size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants