Fix derived temperature output in DiskGalaxy#1960
Draft
BenWibking wants to merge 9 commits into
Draft
Conversation
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ComputeDerivedVar function in testDiskGalaxy.cpp to include magnetic energy when calculating the gas internal energy (Eint). The reviewer suggested using the existing helper function HydroSystem<DiskGalaxy>::ComputeInternalEnergy to simplify the code, avoid manual momentum extraction, and reduce duplication.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…red fields to integrand Move computeVolumeIntegral from AMRSimulation member to free function template in src/util/volume_integral.hpp. The integrand lambda now receives both cell-centered and face-centered state arrays, enabling MHD-correct internal energy computation. Fix DiskGalaxy ComputeStatistics cold mass diagnostic to use HydroSystem::ComputeInternalEnergy (subtracts magnetic energy) instead of RadSystem::ComputeEintFromEgas (only subtracts kinetic energy).
Contributor
|
/claude-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the derived
temperatureoutput var in plotfiles (and slices/projections).Previously, the magnetic field was not subtracted from the total energy when computing this, and so the temperature output was wrong unless the magnetic field was negligible.
Note that this did not affect the evolution of the simulation itself. The conserved variables saved in plotfiles are still correct.
Related issues
N/A
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.