Skip to content

trigger reivew#1989

Closed
chongchonghe wants to merge 3 commits into
developmentfrom
chong/test/trigger-claudhreview
Closed

trigger reivew#1989
chongchonghe wants to merge 3 commits into
developmentfrom
chong/test/trigger-claudhreview

Conversation

@chongchonghe

Copy link
Copy Markdown
Contributor

Description

trigger a review

Related issues

None.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@chongchonghe

Copy link
Copy Markdown
Contributor Author

/claude-review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a placeholder comment to the end of src/main.cpp. The reviewer correctly identified this as temporary code and recommended its removal along with the surrounding blank lines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

src/main.cpp (107-109)

medium

This comment and the surrounding blank lines appear to be placeholder or temporary code and should be removed.

@chongchonghe

Copy link
Copy Markdown
Contributor Author

/claude-review

@chongchonghe

Copy link
Copy Markdown
Contributor Author

/claude-review

🤖 Generated with Claude Code

The issue_comment trigger was passing an empty prompt because the PR-number
expression only handled workflow_dispatch. Claude spent all 30 turns trying
to discover the PR via env/printenv/shell-expansion (all denied).

Fix: extend the prompt expression to inject 'Review PR #N in repo' for all
three trigger types (workflow_dispatch, issue_comment, pull_request).

Also expand settings.json allowlist with the commands Claude actually needs:
git fetch, gh api, cat/head/tail/echo, env, printenv.
@BenWibking BenWibking closed this Jun 26, 2026
@chongchonghe chongchonghe deleted the chong/test/trigger-claudhreview branch June 27, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants