fix(ci): use merge base in quick pipelines to detect changed problems#1994
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Previously, the quick pipelines compared HEAD to FETCH_HEAD (the current tip of development), so any commits merged into development since the PR branched off would appear as "changed" — causing more problems to be built and tested than the PR actually touched. Switch to git merge-base to find the common ancestor, then diff from that point to HEAD, so only the PR's own changes are detected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dosubot
Bot
added
size:XS
Contributor
Author
|
/azp run rocm-quick 🤖 Generated with Claude Code |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6db8dc1bdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run rocm-quick |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
/azp run rocm-quick |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azp run rocm-quick |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run rocm-quick |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run rocm-quick |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BenWibking
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the "Detect changed problems" step in the quick CI pipelines to diff against the merge base rather than the tip of the target branch.
Previously,
git diff --name-only FETCH_HEAD HEADcompared the PR's HEAD to the current tip ofdevelopment. Because most PRs branch off an older commit, any problem files merged intodevelopmentafter the branch point also appeared as "changed" — causing the quick pipeline to build and test far more problems than the PR actually touched. The fix fetches enough history (--deepen=100) and usesgit merge-base FETCH_HEAD HEADto find the true common ancestor, then diffs only from that point to HEAD.Related issues
N/A
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.