Skip to content

ci: trigger Claude code review on /claude-review PR comments#2003

Merged
BenWibking merged 10 commits into
developmentfrom
chong/workfflows/claude
Jun 26, 2026
Merged

ci: trigger Claude code review on /claude-review PR comments#2003
BenWibking merged 10 commits into
developmentfrom
chong/workfflows/claude

Conversation

@chongchonghe

@chongchonghe chongchonghe commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Rework the two Claude GitHub Actions workflows following the official documentation. claude-code-review.yml now runs the code review on a manual trigger — a /claude-review comment on a PR — instead of the previous mix of workflow_dispatch, label, and comment triggers, and is aligned with the upstream anthropics/claude-code-action review template (progress tracking + inline review comments). claude.yml is brought back in line with the official starter template.

claude-code-review.yml:

  • Trigger reduced to issue_comment + an if: guard that only fires on PR comments containing /claude-review (manual, opt-in review).
  • Adopt the upstream review template: track_progress: true and claude_args --allowedTools for inline comments via mcp__github_inline_comment__create_inline_comment plus gh pr tooling.
  • Fix PR-number reference: issue_comment events have no github.event.pull_request object, so the prompt now uses github.event.issue.number (which is the PR number for PR comments).
  • Checkout the PR head (ref: refs/pull/${{ github.event.issue.number }}/head) so the review reads the PR's code, not the default branch (the default for issue_comment events).
  • Drop the now-unneeded issues: write permission and the pinned model / max-turns args, matching the upstream template.

claude.yml:

  • Realign with the official starter template; move actions: read into the job permissions block (replacing the old additional_permissions input) and drop the pinned model / max-turns args.

Note: because issue_comment workflows always run from the default branch, the new trigger behavior only takes effect after this PR merges to development.

Related issues

Replaces #1991

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@chongchonghe

Copy link
Copy Markdown
Contributor Author

/claude-review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds temporary test comments to src/main.cpp. The reviewer recommends removing these test comments before merging to production to maintain a clean codebase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main.cpp Outdated
@chongchonghe

Copy link
Copy Markdown
Contributor Author

/claude-review

@chongchonghe chongchonghe marked this pull request as ready for review June 26, 2026 07:03
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jun 26, 2026
@chongchonghe chongchonghe enabled auto-merge June 26, 2026 07:05
@chongchonghe chongchonghe marked this pull request as draft June 26, 2026 07:06
auto-merge was automatically disabled June 26, 2026 07:06

Pull request was converted to draft

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2066f5592

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/claude.yml Outdated
Comment thread src/main.cpp Outdated
@chongchonghe chongchonghe changed the title test of claude review ci: trigger Claude code review on /claude-review PR comments Jun 26, 2026
@chongchonghe chongchonghe marked this pull request as ready for review June 26, 2026 07:42
@chongchonghe

Copy link
Copy Markdown
Contributor Author

@BenWibking Ready for review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2534a71de0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/claude.yml
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2026
@BenWibking BenWibking added this pull request to the merge queue Jun 26, 2026
Merged via the queue into development with commit 13539af Jun 26, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants