Merged
Conversation
This was referenced May 20, 2025
Merged
freddiev4
force-pushed
the
freddiev4/instructor-client
branch
from
bbec695 to
813a4fa
Compare
freddiev4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates what we have for LLM clients to use
instructorfor its ease of use. It's well maintained and offers a simple interface for multiple LLM providers.from_provider('<provider>/<model-name>')minus support for ollama with this interface (x-ref: 567-labs/instructor#1533).This also removes the need for installing extras like
[auto]and[litellm].There were several issues with
litellmI ran into trying to run local models, and also supporting 3 different clients was just making things very messy from a dependency management and LLM client management perspective.This should also address issues in #19.
TODO: