[PoC] - New "Translations" and "Settings" options in the 3 dots verse menu #3189
Open
[PoC] - New "Translations" and "Settings" options in the 3 dots verse menu #3189
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new entries to the verse overflow (“3 dots”) actions menu to deep-link into Settings (general + translations), and adjusts modal/drawer layering so the Settings drawer can be used while Study Mode is open.
Changes:
- Add
TranslationsandSettingsactions to the verse overflow actions menu. - Add
isModalsupport toContentModal(RadixDialog.Root modal), and use it in Study Mode to allow interacting with SettingsDrawer. - Adjust SettingsDrawer styling when Study Mode is open (z-index/border) so it can overlay the Study Mode modal.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/dls/ContentModal/ContentModal.types.ts | Adds isModal?: boolean to ContentModal props. |
| src/components/dls/ContentModal/ContentModal.tsx | Plumbs isModal through to Radix Dialog.Root modal. |
| src/components/Verse/VerseActionTranslationsSettings.tsx | New verse menu item to open SettingsDrawer directly on Translations view. |
| src/components/Verse/VerseActionSettings.tsx | New verse menu item to open SettingsDrawer on the main Settings view. |
| src/components/Verse/OverflowVerseActionsMenuBody/index.tsx | Wires new verse actions into the overflow menu. |
| src/components/QuranReader/ReadingView/StudyModeModal/index.tsx | Makes Study Mode dialog non-modal while SettingsDrawer is open. |
| src/components/Navbar/SettingsDrawer/SettingsDrawer.tsx | Applies an additional drawer class while Study Mode is open. |
| src/components/Navbar/Drawer/Drawer.module.scss | Adds .studyModeOverlayLevel to raise drawer z-index and tweak border. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 300718d1ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two new buttons to the verse context menu:
Closes: N/A
Type of Change
Scope Confirmation
Test Plan
Testing steps:
Code Quality
anytypes used (or justified if unavoidable)Testing & Validation
yarn test) (two unrelated tests fail)yarn lint)yarn build)Localization (if UI changes)
next-translateScreenshots / Videos
2026-02-20_22-14-00.mp4
AI Assistance Disclosure