Skip to content

[PoC] - New "Translations" and "Settings" options in the 3 dots verse menu #3189

Open
zonetecde wants to merge 4 commits intotestingfrom
poc-dot-menu-extra-options
Open

[PoC] - New "Translations" and "Settings" options in the 3 dots verse menu #3189
zonetecde wants to merge 4 commits intotestingfrom
poc-dot-menu-extra-options

Conversation

@zonetecde
Copy link
Collaborator

Summary

This PR adds two new buttons to the verse context menu:

  • One to open the translation selection settings
  • One to open the general settings

Closes: N/A

Type of Change

  • ✨ New feature (non-breaking change that adds functionality)

Scope Confirmation

  • This PR addresses one feature/fix only
  • If multiple changes were needed, they are split into separate PRs

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Testing steps:

  1. Tested both context menu options in translation mode
  2. Tested in Study mode
  3. Tested refresh behavior, back button, done button, and click-outside behavior

Code Quality

  • I have performed a self-review of my code (file by file)
  • My code follows the project style guidelines
  • No any types used (or justified if unavoidable)
  • No unused code, imports, or dead code included
  • Complex logic has inline comments explaining "why"
  • Functions are under 30 lines and follow the single-responsibility principle

Testing & Validation

  • All tests pass locally (yarn test) (two unrelated tests fail)
  • Linting passes (yarn lint)
  • Build succeeds (yarn build)
  • Edge cases and error scenarios are handled

Localization (if UI changes)

  • All user-facing text uses next-translate
  • Only English locale files modified (Lokalise handles others)
  • RTL layout verified

Screenshots / Videos

2026-02-20_22-14-00.mp4

AI Assistance Disclosure

  • AI tools were NOT used for this PR
  • AI tools were used, and I have thoroughly reviewed and validated all generated code

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new entries to the verse overflow (“3 dots”) actions menu to deep-link into Settings (general + translations), and adjusts modal/drawer layering so the Settings drawer can be used while Study Mode is open.

Changes:

  • Add Translations and Settings actions to the verse overflow actions menu.
  • Add isModal support to ContentModal (Radix Dialog.Root modal), and use it in Study Mode to allow interacting with SettingsDrawer.
  • Adjust SettingsDrawer styling when Study Mode is open (z-index/border) so it can overlay the Study Mode modal.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/components/dls/ContentModal/ContentModal.types.ts Adds isModal?: boolean to ContentModal props.
src/components/dls/ContentModal/ContentModal.tsx Plumbs isModal through to Radix Dialog.Root modal.
src/components/Verse/VerseActionTranslationsSettings.tsx New verse menu item to open SettingsDrawer directly on Translations view.
src/components/Verse/VerseActionSettings.tsx New verse menu item to open SettingsDrawer on the main Settings view.
src/components/Verse/OverflowVerseActionsMenuBody/index.tsx Wires new verse actions into the overflow menu.
src/components/QuranReader/ReadingView/StudyModeModal/index.tsx Makes Study Mode dialog non-modal while SettingsDrawer is open.
src/components/Navbar/SettingsDrawer/SettingsDrawer.tsx Applies an additional drawer class while Study Mode is open.
src/components/Navbar/Drawer/Drawer.module.scss Adds .studyModeOverlayLevel to raise drawer z-index and tweak border.

@zonetecde zonetecde marked this pull request as ready for review February 23, 2026 20:49
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 300718d1ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants