Skip to content

LPs: isr#3230

Open
mustafa0x wants to merge 1 commit intotestingfrom
lp-isr
Open

LPs: isr#3230
mustafa0x wants to merge 1 commit intotestingfrom
lp-isr

Conversation

@mustafa0x
Copy link
Contributor

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3ca5b370d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

)) as any
}
/>
<CourseDetails course={course} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore per-user course fetch for detail page

Rendering CourseDetails directly from getStaticProps data makes the page use a single cached course payload for all visitors, so user-specific fields like isUserEnrolled, continueFromLesson, and userHasFeedback can no longer be personalized. In practice, logged-in users who are already enrolled can be shown the guest/enroll state (via StatusHeader) instead of the continue flow, because the authenticated privateFetcher(makeGetCourseUrl(...)) call that previously hydrated per-user state was removed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant