Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for “related verse” relationships spanning a verse range (from/to) and updates the Study Mode UI to present related verses in a collapsible section, with supporting style utilities and minor RTL cleanup.
Changes:
- Update
RelatedVerseshape to include*From/*Toidentifiers/keys/names for ranged relations. - Render related verse ranges via
/verses/by_rangeand display them inside aCollapsiblein Study Mode. - Add new edge margin SCSS mixins and remove a now-unneeded RTL tabs container style hook.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
types/RelatedVerse.ts |
Extends related-verse model to represent verse ranges (from/to). |
src/styles/_utility.scss |
Adds edge margin mixins analogous to existing edge padding mixins. |
src/components/QuranReader/TranslationView/TranslationViewCell.module.scss |
Removes .tabsContainerRTL styles. |
src/components/QuranReader/TranslationView/BottomActionsTabs.tsx |
Stops applying the removed RTL container class. |
src/components/QuranReader/ReadingView/StudyModeModal/tabs/StudyModeRelatedVerses/StudyModeRelatedVerses.module.scss |
Refactors styles for the new collapsible/range layout. |
src/components/QuranReader/ReadingView/StudyModeModal/tabs/StudyModeRelatedVerses/StudyModeRelatedVerseContent.tsx |
Switches from single-verse fetch/render to ranged fetch/render with collapsible UI and localized titles. |
...ader/ReadingView/StudyModeModal/tabs/StudyModeRelatedVerses/StudyModeRelatedVerseContent.tsx
Show resolved
Hide resolved
...ader/ReadingView/StudyModeModal/tabs/StudyModeRelatedVerses/StudyModeRelatedVerseContent.tsx
Show resolved
Hide resolved
...ader/ReadingView/StudyModeModal/tabs/StudyModeRelatedVerses/StudyModeRelatedVerseContent.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48b0bfb247
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
Testing branch: new related verse
Type of Change
expected)
If Breaking Change
Scope Confirmation
Environment Variables
EXAMPLE_VARRollback Safety
Test Plan
Testing steps:
Edge Cases Verified
Pre-Review Checklist
Code Quality
anytypes used (or justified if unavoidable)Testing & Validation
yarn test)yarn lint)yarn build)Documentation
Localization (if UI changes)
next-translateAccessibility (if UI changes)
Screenshots/Videos
Related PRs
Reviewer Notes
AI Assistance Disclosure