fix: agent-runner source not updating for existing groups#1053
Open
wenkang-xie wants to merge 1 commit intoqwibitai:mainfrom
Open
fix: agent-runner source not updating for existing groups#1053wenkang-xie wants to merge 1 commit intoqwibitai:mainfrom
wenkang-xie wants to merge 1 commit intoqwibitai:mainfrom
Conversation
The previous logic copied agent-runner source to a per-group cache on first run and never updated it. This meant new MCP tools or bug fixes to ipc-mcp-stdio.ts would never reach existing groups. Replace with a two-layer mount approach: - /app/src-global (read-only): always-current global source - /app/src-custom (read-write): per-group tool overrides/additions - Entrypoint merges both into /tmp/src before compilation Global updates propagate automatically on next container start. Per-group custom files are preserved. Same-named files: custom wins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
Andy-NanoClaw-AI
added
Status: Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src-global(read-only, shared) +src-custom(read-write, per-group overrides)/tmp/srcat startup, compiles with a pre-builttsconfig.build.json, and symlinksnode_modulesfrom/appChanges
src/container-runner.ts!fs.existsSynccopy-once logic with two-layer mount (src-global+src-custom)container/Dockerfiletsconfig.build.jsontargeting/tmp/srcRoot cause
The original code checked
if (!fs.existsSync(groupAgentRunnerDir))before copying source, meaning once a group's source directory existed, it was never updated. Any new MCP tools added tocontainer/agent-runner/src/would only appear for newly created groups.Test plan
npm run buildpassesnpm testpasses (271 tests)./container/build.shsrc-custommount🤖 Generated with Claude Code