Use Snowflake config.toml/connection.toml files #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for loading connection parameters from TOML config files (~/.snowflake/connections.toml and config.toml) following the Python Snowflake connector conventions. New features: - `connection_name` parameter to load a named connection profile - `connections_file_path` parameter to specify custom config location - Support for SNOWFLAKE_CONNECTIONS env var (full TOML override) - Support for SNOWFLAKE_DEFAULT_CONNECTION_NAME env var - File permission security checks (error on writable, warn on readable) - Graceful fallback when toml package not installed Connection resolution: - Case 1: connection_name provided → load and merge with kwargs - Case 2: No args → load default connection from config - Case 3: Programmatic params → use params only, skip config loading SNOWFLAKE_ACCOUNT env var is only used in Case 3 (programmatic mode), not when loading from config files. Requires the toml package (Suggests) for config file parsing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Two issues fixed: 1. When config file had `user` + `authenticator` (no password), the `uid` and `authenticator` values ended up in both `args` and `auth`, causing "formal argument matched by multiple actual arguments" error. Fixed by nulling auth params from `args` before merging with `auth`. 2. `snowflake_auth_args()` wasn't returning `authenticator` when using uid + authenticator (externalbrowser/SNOWFLAKE_JWT), so the authenticator from config file was lost and the "Failed to detect ambient credentials" error was thrown. Added tests for config files with user + authenticator (no password). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
jcheng5
changed the title
jcheng5
commented
Dec 16, 2025
jcheng5
commented
Dec 16, 2025
jcheng5
commented
Dec 16, 2025
jcheng5
commented
Dec 16, 2025
jcheng5
commented
Dec 16, 2025
jcheng5
commented
Dec 17, 2025
jcheng5
commented
Dec 17, 2025
Two issues fixed: 1. SNOWFLAKE_CONNECTIONS env var was preventing reading of default_connection_name from config.toml. Now each config option is resolved independently, matching Python connector behavior. 2. Missing toml package gave misleading "connection not found" error instead of "toml package required" when config files existed. Now errors appropriately when TOML parsing is actually needed. Implementation uses delayedAssign() for lazy promise-based evaluation: - Only parses TOML sources that are actually needed - toml package error only triggers when parsing is required - Clean precedence logic via %||% chains, no complex conditionals 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
simonpcouch
reviewed
Dec 17, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
I don't have strong reflexes here on the big idea, but trust that this is a reasonable approach! Reviewing for R code style etc.
Could you add a NEWS entry?
Collaborator
|
Fine to ignore the two failing checks. |
jcheng5
force-pushed
the
snowflake-config-files
branch
from
cce831b to
34f87e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vibe coded; just for discussion purposes for nowExtremely carefully reviewed by @jcheng5, except unit tests (life is too short)Add support for loading connection parameters from TOML config files (~/.snowflake/connections.toml and config.toml) following the Python Snowflake connector conventions.
New features:
connection_nameparameter to load a named connection profileconnections_file_pathparameter to specify custom config locationConnection resolution:
SNOWFLAKE_ACCOUNT env var is only used in Case 3 (programmatic mode), not when loading from config files.
Requires the toml package (Suggests) for config file parsing.
🤖 Generated with Claude Code