Skip to content

dbi-table: No special handling for data.table::IDate #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detule wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dbi-table: No special handling for data.table::IDate #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions R/dbi-table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ setMethod("sqlData", "OdbcConnection",
is_POSIXlt <- vapply(value, function(x) is.object(x) && (is(x, "POSIXlt")), logical(1))
value[is_POSIXlt] <- lapply(value[is_POSIXlt], as.POSIXct)

# Convert data.table::IDate to Date
is_IDate <- vapply(value, function(x) is.object(x) && (is(x, "IDate")), logical(1))
value[is_IDate] <- lapply(value[is_IDate], as.Date)

# C code takes care of atomic vectors, dates, date times, and blobs just need to coerce other objects
is_object <- vapply(value, function(x) is.object(x) && !(is(x, "POSIXct") || is(x, "Date") || is_blob(x) || is(x, "difftime")), logical(1))
value[is_object] <- lapply(value[is_object], as.character)
Expand Down
Loading