Open
Conversation
SaranjeetKaur
changed the title
Collaborator
Author
|
Also tagging @jyoti-bhogal for a review as she was interested in this issue. |
hturner
reviewed
Dec 6, 2024
Member
hturner
left a comment
hturner
left a comment
There was a problem hiding this comment.
Suggest adding this as a section in the lifecycle of a patch chapter instead. Reorder sections as follows:
- When do you submit a patch?
- Coding style
- Making good patches
- What tools are required to submit a patch?
- How to prepare a patch?
| - Use `TRUE` and `FALSE`, not `T` and `F`. | ||
| - Keep lines no longer than 80 characters. | ||
| - Avoid using special characters in file names (numbers, letters, `-`, and `_` are acceptable). | ||
| - Put a space after (not before) a comma. |
Member
There was a problem hiding this comment.
already have this as second point
Suggested change
| - Put a space after (not before) a comma. |
pauamma
added a commit
that referenced
this pull request
Dec 16, 2025
- Copied most of the text by @SaranjeetKaur from #216 with a few minor changes. - Applied #216#pullrequestreview-2485206377 comments by @hturner, with one deviation from her suggested order.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
This PR adds a new chapter on R coding style.