Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a package for helpers related to patches #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Sep 10, 2024

Basically, a packaged up version of the scripts at https://contributor.r-project.org/translations/Weblate-server.html#to-submit-a-patch-file-on-the-translations-found-in-weblate-but-not-in-the-trunk-of-the-main-r-subversion-repo.

Not completely done package-izing it yet. Checking in for feedback now since I ran out of steam :)

The original motivation here is I started to think about how to generate patches for the Recommended packages, figured it would involve re-using this script with slight edits over & over, rather seems easier to make it a package instead (I hope). I don't intend for this package to be on CRAN, I don't think it's general-purpose enough (certainly not anytime soon). Just a highly-specialized helper package for our purposes here.

I'm not sure if this repo is the right place for this package to live, WDYT @hturner @daroczig?

@daroczig
Copy link
Member

great idea, thanks! probably we should add the helper python scripts as well under inst so that we don't have to keep it in the weblate repo and its clone mirror on GH as a backup?

@MichaelChirico
Copy link
Contributor Author

SGTM; it does mean we'll have to install R 😅 (the reason those are written in Python in the first place)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants