Make a package for helpers related to patches #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great idea, thanks! probably we should add the helper python scripts as well under |
|
SGTM; it does mean we'll have to install R 😅 (the reason those are written in Python in the first place) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, a packaged up version of the scripts at https://contributor.r-project.org/translations/Weblate-server.html#to-submit-a-patch-file-on-the-translations-found-in-weblate-but-not-in-the-trunk-of-the-main-r-subversion-repo.
Not completely done package-izing it yet. Checking in for feedback now since I ran out of steam :)
The original motivation here is I started to think about how to generate patches for the Recommended packages, figured it would involve re-using this script with slight edits over & over, rather seems easier to make it a package instead (I hope). I don't intend for this package to be on CRAN, I don't think it's general-purpose enough (certainly not anytime soon). Just a highly-specialized helper package for our purposes here.
I'm not sure if this repo is the right place for this package to live, WDYT @hturner @daroczig?