Skip to content

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Dec 30, 2025

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps jfmengels/elm-review-simplify from 2.1.10 to 2.1.11.

Changelog

Sourced from jfmengels/elm-review-simplify's changelog.

[2.1.11] - 2025-12-30

  • Disabled List.concat simplifications that merged List.concat without structure.
grid =
    List.concat
        [ [ O, X, X ]
        , [ O, O, X ]
        , [ X, O, O ]
        ]
--> previously
grid =
    [ O, X, X, O, O, X, X, O, O ]

This simplification made it sometimes harder to understand the data, and is therefore getting removed. It will however still apply when there doesn't seem to be any structure, i.e. when the list is one line or when all sub-items are on different lines.

  • [ 1, 2 ] ++ [ 3, 4 ] has also partially been disabled with similar logic.

The rule now simplifies:

  • Maybe.withDefault Nothing (Maybe.map f maybe) to Maybe.andThen f maybe
  • List.reverse (List.repeat n a) to List.repeat n a
  • List.sort (List.repeat n a) to List.repeat n a
  • List.sortBy f (List.repeat n a) to List.repeat n a
  • List.sortWith f (List.repeat n a) to List.repeat n a
  • Dict.update k identity dict to dict
  • Dict.update k (\_ -> Nothing) dict to Dict.remove k dict
  • Dict.update k (\_ -> Just v) dict to Dict.insert k v dict
  • "a" ++ "" ++ x" to "a" ++ "x" in more cases
  • "a" ++ "b" to "ab" when the two strings start and end on the same line
  • List.filter f (List.filter f list) to List.filter f list
  • Array.filter f (Array.filter f array) to Array.filter f array
  • Set.filter f (Set.filter f set) to Set.filter f set
  • Dict.filter f (Dict.filter f dict) to Dict.filter f dict
  • Set.insert k (Set.insert k set) to Set.insert k set
  • Dict.insert k v1 (Dict.insert k v0 dict) to Dict.insert k v1 dict
  • Array.set i v1 (Array.set i v0 array) to Array.set i v1 array
  • Set.remove k (Set.remove k set) to Set.remove k set
  • Dict.remove k (Dict.remove k dict) to Dict.remove k dict
  • List.take n (List.take n list) to List.take n list
  • String.left n (String.left n string) to String.left n string
  • String.right n (String.right n string) to String.right n string
  • Basics.abs (Basics.abs n) to Basics.abs n
  • Basics.abs -n to Basics.abs n
  • Basics.abs 3 to 3
  • Basics.min n n to n
  • Basics.min n -n to -(Basics.abs n)
  • Basics.min (Basics.min n0 n1) n0 to Basics.min n0 n1 (any equal inner values across the two arguments, or composition)
  • Basics.min 3 4 to 3
  • Basics.max n n to n

... (truncated)

Commits
  • 4a2b2d8 2.1.11
  • 79f202b add Dict.foldr to entry list checks
  • 2b58647 Introduce helper to reduce lambdas and use it to improve normalize
  • a221df4 correct expectNaN notes in simplification summary
  • e73f45d add Dict.foldr to keys/values checks
  • 3cd546e add Dict.fold Dict.insert Dict.empty checks
  • 6f32877 add Set.fold Set.insert Set.empty checks
  • 4e35654 add Set.foldr (::) [] check
  • 4a27ed3 add List.foldl (::) [] check
  • 4161d49 Add List.foldr (::) [] check
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jfmengels/elm-review-simplify](https://github.com/jfmengels/elm-review-simplify) from 2.1.10 to 2.1.11.
- [Changelog](https://github.com/jfmengels/elm-review-simplify/blob/main/CHANGELOG.md)
- [Commits](jfmengels/elm-review-simplify@2.1.10...2.1.11)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review-simplify
  dependency-version: 2.1.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels Dec 30, 2025
@dependabot dependabot bot requested a review from r-k-b as a code owner December 30, 2025 19:14
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels Dec 30, 2025
@r-k-b r-k-b merged commit 01cf45a into main Dec 31, 2025
1 check passed
@dependabot dependabot bot deleted the dependabot/elm/review/jfmengels/elm-review-simplify-2.1.11 branch December 31, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file elm Pull requests that update Elm code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant