Skip to content

Fix prototype for R_bit_set_attr #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 2 commits into from
Feb 11, 2025
Merged

Fix prototype for R_bit_set_attr #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
599fb0e
Fix prototype for R_bit_set_attr
MichaelChirico Feb 10, 2025
e8171eb
missing 'return'
MichaelChirico Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# bit 4.5.99

## BUG FIXES

1. Corrected the function prototype for a C function, #36. Thanks @aitap for investigating and suggesting a fix.

## NOTES

1. After creating, developing, and maintaining {bit} for about 16 years, Jens Oehlschlägel has decided to step down as maintainer of the package. As with {bit64}, Michael Chirico will take over in this duty. Thank you Jens for creating such a wonderful & important part of the R ecosystem!
Expand Down
4 changes: 2 additions & 2 deletions src/attrutil.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include <R.h>
#include <Rinternals.h>

void R_bit_set_attr(SEXP x, SEXP which, SEXP value)
SEXP R_bit_set_attr(SEXP x, SEXP which, SEXP value)
{
/* xx looking at R sources setAttrib would directly accept a string, however this is not documented */
setAttrib(x, install(CHAR(STRING_ELT(which, 0))), value);
return setAttrib(x, install(CHAR(STRING_ELT(which, 0))), value);
}
Loading