-
Notifications
You must be signed in to change notification settings - Fork 13
Add matrix, array and matrix multiplication for integer64 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
b40f6c1
add matrix, array, %*%.integer64
hcirellu e781e13
fix sys.call level in target_class_for_Ops
hcirellu 400fb45
fix tests to run with ubuntu-latest (3.6) and macos-latest (release)
hcirellu d9e0f7d
fix matrix multiplication for macos
hcirellu 6421d8e
manual debug macos
hcirellu 0777b57
debug macos
hcirellu e48e746
debug macos
hcirellu c6aa44f
debug macos
hcirellu df8a02d
debug macos
hcirellu 58532f2
fix for macos
hcirellu b334ccd
Update R/integer64.R
hcirellu c3245d1
Update R/integer64.R
hcirellu 63a394c
rename `dimO` to `obj_dim`
hcirellu c765dac
`dim` or `dims` is allowed in error message
hcirellu 2ba1592
remove dependency from package `patrick` for testing
hcirellu 98220d3
remove package `patrick` from DESCRIPTION
hcirellu b65c95d
Revert "remove package `patrick` from DESCRIPTION"
hcirellu 4604631
Revert "remove dependency from package `patrick` for testing"
hcirellu d72712e
Merge branch 'main' into matrix_array_matmult
MichaelChirico ccea4aa
Merge branch 'main' into matrix_array_matmult
hcirellu f7b3c7a
use skip_unless_r()
hcirellu 8f685a0
backport `errorCondition()` and `warningCondition()`
hcirellu 8382964
debug of test-ancient
hcirellu 7cff847
Revert "debug of test-ancient"
hcirellu 1c623b0
Merge branch 'main' into matrix_array_matmult
MichaelChirico b6bf9fe
try fixing ancient-test
hcirellu 71d0763
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu c49fafe
Merge branch 'main' into matrix_array_matmult
hcirellu 621dc27
reduce duplication in tests
hcirellu 67bf8f3
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu 828ca3c
small fix for ignore_attr
hcirellu f132dc5
Merge branch 'main' into matrix_array_matmult
MichaelChirico 9ba6447
implicit assignment of `obj_dim`
hcirellu 05b7796
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu e70687d
Merge branch 'main' into matrix_array_matmult
hcirellu 4135218
Merge branch 'main' into matrix_array_matmult
MichaelChirico a53f096
ws
MichaelChirico abaa1d5
revert keep.names= again
MichaelChirico a59e5af
Merge branch 'main' into matrix_array_matmult
MichaelChirico 1b1769f
restore sync of method + generic signatures
MichaelChirico 6fc7b68
restore sync of method + generic signatures
MichaelChirico dd1eefd
helpers added `choose_sys_call()` and `withCallingHandlers_and_choose…
hcirellu 2474aff
add named arguments for base calls of default methods colSums and row…
hcirellu f1ed4ce
extend binary operator contract table
hcirellu d278649
add nice calls in condition messages for colSums and rowSums default …
hcirellu eef6a7c
move S3 generics and defaults to patch64.R
hcirellu f6dfc1a
convert `.onLoad()` into if statement
hcirellu ad2bb9f
remove unnecessary `as.integer` in tests
hcirellu 30c86e0
Merge branch 'main' into matrix_array_matmult
hcirellu 204e200
update matrix64.Rd
hcirellu 3377e6d
style on backports
MichaelChirico 9c7b2f2
try to use local() for clarity
MichaelChirico 84acaf7
reduce redundancy with {patrick}
MichaelChirico 959cb49
do we even need local()?
MichaelChirico 91c15b3
comments
MichaelChirico a8439c0
fix patrick translation, remove expect_no_warning() by default
MichaelChirico 76e9beb
remove more expect_no_warning()
MichaelChirico 70eae32
more post-patrick fixes, readability
MichaelChirico cbe9f75
typo integer->integer64
MichaelChirico 3bee116
Need to pass '...' to grepl()
MichaelChirico c8db889
trying with substitute()
MichaelChirico 23da2df
missing ')'
MichaelChirico 44441db
avoid rep_len() for ancient
MichaelChirico b622074
Merge branch 'r-lib:main' into matrix_array_matmult
hcirellu 073cd30
documentation of `choose_sys_call()`
hcirellu f4d5308
add `as.integer64(x)` in `as.matrix.integer64`
hcirellu 5a06955
mark rep_len for TODO
MichaelChirico ff054ab
Merge branch 'main' into matrix_array_matmult
MichaelChirico 1f3e934
simplify
MichaelChirico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.