Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
b40f6c1
add matrix, array, %*%.integer64
hcirellu Nov 25, 2025
e781e13
fix sys.call level in target_class_for_Ops
hcirellu Nov 26, 2025
400fb45
fix tests to run with ubuntu-latest (3.6) and macos-latest (release)
hcirellu Nov 26, 2025
d9e0f7d
fix matrix multiplication for macos
hcirellu Nov 26, 2025
6421d8e
manual debug macos
hcirellu Nov 26, 2025
0777b57
debug macos
hcirellu Nov 26, 2025
e48e746
debug macos
hcirellu Nov 26, 2025
c6aa44f
debug macos
hcirellu Nov 26, 2025
df8a02d
debug macos
hcirellu Nov 26, 2025
58532f2
fix for macos
hcirellu Nov 26, 2025
b334ccd
Update R/integer64.R
hcirellu Dec 13, 2025
c3245d1
Update R/integer64.R
hcirellu Dec 13, 2025
63a394c
rename `dimO` to `obj_dim`
hcirellu Dec 13, 2025
c765dac
`dim` or `dims` is allowed in error message
hcirellu Dec 13, 2025
2ba1592
remove dependency from package `patrick` for testing
hcirellu Dec 29, 2025
98220d3
remove package `patrick` from DESCRIPTION
hcirellu Dec 29, 2025
b65c95d
Revert "remove package `patrick` from DESCRIPTION"
hcirellu Dec 30, 2025
4604631
Revert "remove dependency from package `patrick` for testing"
hcirellu Dec 30, 2025
d72712e
Merge branch 'main' into matrix_array_matmult
MichaelChirico Dec 30, 2025
ccea4aa
Merge branch 'main' into matrix_array_matmult
hcirellu Jan 3, 2026
f7b3c7a
use skip_unless_r()
hcirellu Jan 3, 2026
8f685a0
backport `errorCondition()` and `warningCondition()`
hcirellu Jan 3, 2026
8382964
debug of test-ancient
hcirellu Jan 3, 2026
7cff847
Revert "debug of test-ancient"
hcirellu Jan 3, 2026
1c623b0
Merge branch 'main' into matrix_array_matmult
MichaelChirico Jan 3, 2026
b6bf9fe
try fixing ancient-test
hcirellu Jan 3, 2026
71d0763
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu Jan 3, 2026
c49fafe
Merge branch 'main' into matrix_array_matmult
hcirellu Jan 5, 2026
621dc27
reduce duplication in tests
hcirellu Jan 5, 2026
67bf8f3
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu Jan 5, 2026
828ca3c
small fix for ignore_attr
hcirellu Jan 5, 2026
f132dc5
Merge branch 'main' into matrix_array_matmult
MichaelChirico Jan 5, 2026
9ba6447
implicit assignment of `obj_dim`
hcirellu Jan 5, 2026
05b7796
Merge branch 'matrix_array_matmult' of https://github.com/hcirellu/bi…
hcirellu Jan 5, 2026
e70687d
Merge branch 'main' into matrix_array_matmult
hcirellu Jan 6, 2026
4135218
Merge branch 'main' into matrix_array_matmult
MichaelChirico Jan 6, 2026
a53f096
ws
MichaelChirico Jan 6, 2026
abaa1d5
revert keep.names= again
MichaelChirico Jan 6, 2026
a59e5af
Merge branch 'main' into matrix_array_matmult
MichaelChirico Jan 6, 2026
1b1769f
restore sync of method + generic signatures
MichaelChirico Jan 6, 2026
6fc7b68
restore sync of method + generic signatures
MichaelChirico Jan 6, 2026
dd1eefd
helpers added `choose_sys_call()` and `withCallingHandlers_and_choose…
hcirellu Jan 7, 2026
2474aff
add named arguments for base calls of default methods colSums and row…
hcirellu Jan 7, 2026
f1ed4ce
extend binary operator contract table
hcirellu Jan 7, 2026
d278649
add nice calls in condition messages for colSums and rowSums default …
hcirellu Jan 7, 2026
eef6a7c
move S3 generics and defaults to patch64.R
hcirellu Jan 7, 2026
f6dfc1a
convert `.onLoad()` into if statement
hcirellu Jan 7, 2026
ad2bb9f
remove unnecessary `as.integer` in tests
hcirellu Jan 7, 2026
30c86e0
Merge branch 'main' into matrix_array_matmult
hcirellu Jan 7, 2026
204e200
update matrix64.Rd
hcirellu Jan 7, 2026
3377e6d
style on backports
MichaelChirico Jan 8, 2026
9c7b2f2
try to use local() for clarity
MichaelChirico Jan 8, 2026
84acaf7
reduce redundancy with {patrick}
MichaelChirico Jan 8, 2026
959cb49
do we even need local()?
MichaelChirico Jan 8, 2026
91c15b3
comments
MichaelChirico Jan 8, 2026
a8439c0
fix patrick translation, remove expect_no_warning() by default
MichaelChirico Jan 8, 2026
76e9beb
remove more expect_no_warning()
MichaelChirico Jan 8, 2026
70eae32
more post-patrick fixes, readability
MichaelChirico Jan 8, 2026
cbe9f75
typo integer->integer64
MichaelChirico Jan 8, 2026
3bee116
Need to pass '...' to grepl()
MichaelChirico Jan 8, 2026
c8db889
trying with substitute()
MichaelChirico Jan 8, 2026
23da2df
missing ')'
MichaelChirico Jan 8, 2026
44441db
avoid rep_len() for ancient
MichaelChirico Jan 8, 2026
b622074
Merge branch 'r-lib:main' into matrix_array_matmult
hcirellu Jan 9, 2026
073cd30
documentation of `choose_sys_call()`
hcirellu Jan 9, 2026
f4d5308
add `as.integer64(x)` in `as.matrix.integer64`
hcirellu Jan 9, 2026
5a06955
mark rep_len for TODO
MichaelChirico Jan 9, 2026
ff054ab
Merge branch 'main' into matrix_array_matmult
MichaelChirico Jan 9, 2026
1f3e934
simplify
MichaelChirico Jan 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/matrix64.R
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ as.matrix.integer64 = function(x, ...) {
if (is.matrix(x)) {
x
} else {
array(as.integer64(x), c(length(x), 1L), {if (!is.null(names(x))) list(names(x), NULL) else NULL})
}
array(x, c(length(x), 1L), if (!is.null(names(x))) list(names(x), NULL))

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as.integer64, because I think it is good practice to assure that this method returns integer64, even though it might have been called directly internally without integer64.
But here the result would be inconsistent within the method, because if the input would be a non-integer64 matrix, it would be returned without converting to integer64.
Should I modify it to assure an integer64 return value or leave it as it is?
@MichaelChirico ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I think it's overkill to call as.* again from within a .* S3 method -- if we get non-integer64 input, user is playing with fire :)

We have a few ugly checks in as.data.table.data.frame that are basically there for back-compatibility -- I'd rather the user be stuck debugging such cases:

https://github.com/Rdatatable/data.table/blob/a325db9e0c6a0cd1076c086d5fc17a548bccd1a5/R/as.data.table.R#L254-L261

}
}
Loading