Skip to content

Extend shellsortorder testing #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 1 commit into from
Aug 16, 2026
Merged

Extend shellsortorder testing #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions tests/testthat/test-sort64.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ with_parameters_test_that(

na_entries = rep(NA_integer64_, n_missing)
y = sample(c(x, if (duplicates) x[1L], na_entries))
y_orig = bit::clone(y)
i = seq_along(y)
expect_identical(sortorder_function(y, i, decreasing=decreasing, na.last=na.last), n_missing)
expected_value = c(
Expand All @@ -112,13 +113,12 @@ with_parameters_test_that(
if (duplicates && decreasing) x[1L],
if (na.last) na_entries else integer64()
)
# TODO(#159): Also add expectations for the update to i
expect_identical(y, expected_value,
info=sprintf(
"(na.last, decreasing, duplicates, n_missing)=(%s, %s, %s, %d)",
na.last, decreasing, duplicates, n_missing
)
info = sprintf(
"(na.last, decreasing, duplicates, n_missing)=(%s, %s, %s, %d)",
na.last, decreasing, duplicates, n_missing
)
expect_identical(y, expected_value, info=info)
expect_identical(y_orig[i], expected_value, info=info)
},
.cases = expand.grid(
sortorder_function = list(
Expand Down Expand Up @@ -163,6 +163,7 @@ test_that("Explicit algorithm dispatch hits C-level fallbacks and edge cases", {
i = seq_along(x)
bit::mergesortorder(x, i, decreasing=TRUE)
expect_identical(x, as.integer64(sort(as.integer(x_base), decreasing=TRUE)))
expect_identical(x_base[i], as.integer64(sort(as.integer(x_base), decreasing=TRUE)))

x = bit::clone(x_base)
i = seq_along(x)
Expand Down Expand Up @@ -222,6 +223,7 @@ test_that("Specific sortorder/order variants for Quicksort coverage", {
i = seq_along(x)
bit::quicksortorder(x, i, decreasing=TRUE)
expect_identical(x, as.integer64(sort(as.integer(x_base), decreasing=TRUE)))
expect_identical(x_base[i], as.integer64(sort(as.integer(x_base), decreasing=TRUE)))

# quickorder descending (modifies i, not x)
x = bit::clone(x_base)
Expand All @@ -243,6 +245,18 @@ test_that("Shellsort direct invocation", {
i = seq_along(x)
bit::shellorder(x, i, decreasing=FALSE)
expect_identical(x[i], as.integer64(sort(as.integer(x_base))))

x = bit::clone(x_base)
i = seq_along(x)
bit::shellsortorder(x, i, decreasing=FALSE)
expect_identical(x, as.integer64(sort(as.integer(x_base))))
expect_identical(x_base[i], as.integer64(sort(as.integer(x_base))))

x = bit::clone(x_base)
i = seq_along(x)
bit::shellsortorder(x, i, decreasing=TRUE)
expect_identical(x, as.integer64(sort(as.integer(x_base), decreasing=TRUE)))
expect_identical(x_base[i], as.integer64(sort(as.integer(x_base), decreasing=TRUE)))
})

test_that("Corner cases for partitioning logic", {
Expand Down
Loading