Skip to content

Windows: use libuv from Rtools on (sync with httpuv) #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroen merged 1 commit into from
Mar 5, 2026
+18 −2
Merged

Windows: use libuv from Rtools on (sync with httpuv) #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ jobs:
matrix:
config:
- {os: macos-latest, r: 'release'}

- {os: windows-latest, r: 'devel'}
- {os: windows-latest, r: 'release'}
- {os: windows-latest, r: 'oldrel'}
# use 4.0 or 4.1 to check with rtools40's older compiler
- {os: windows-latest, r: 'oldrel-4'}

Expand Down
15 changes: 15 additions & 0 deletions src/Makevars.ucrt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
SYS_LIBS = $(shell pkg-config --libs zlib libuv)
ifeq ($(SYS_LIBS),)
PKG_LIBS = \
-luv -lpthread -lws2_32 -lkernel32 -lpsapi -liphlpapi -lshell32 -luserenv -lz \
-ldbghelp -luuid -lole32
else
PKG_LIBS = $(SYS_LIBS)
endif

PKG_CFLAGS = $(C_VISIBILITY) -DSTRICT_R_HEADERS
PKG_CXXFLAGS = $(CXX_VISIBILITY) -DSTRICT_R_HEADERS
PKG_CPPFLAGS += -D_WIN32_WINNT=0x0600 -DSTRICT_R_HEADERS

SOURCES = $(wildcard *.cc windows/*.cc)
OBJECTS = $(SOURCES:.cc=.o)
2 changes: 1 addition & 1 deletion src/windows/getmode.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "getmode.h"
#include <sys/stat.h>
#include <string>

#include <R.h>
#include <Rinternals.h> /* for Rf_error */
Expand Down
Loading