Threaded dispatcher with backpressure support#582
Merged
shikokuchuo merged 14 commits intomainfrom Apr 9, 2026
Merged
Conversation
Contributor
|
This is fantastic, @shikokuchuo! I notice a speedup in my long tests, and there I do have a couple unit tests to update in |
shikokuchuo
commented
Apr 9, 2026
Member
Author
shikokuchuo
left a comment
There was a problem hiding this comment.
Revdeps coming in clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454. Closes #581.
Summary
Dispatcher moves from a separate R process to an in-process thread (Threaded dispatcher #581). The dispatcher logic, already reimplemented in C (nanonext 1.8.0), now runs as a thread within the host process. This eliminates inter-process communication overhead for dispatching and status queries, using
inproc://transport instead of IPC sockets.info()reads dispatcher state directly rather than sending a query-response round trip.New
capacityargument fordaemons()(Gating dispatcher based on uncollected results #454). Sets the maximum number of tasks (queued + executing) at the dispatcher. When the limit is reached,mirai()blocks until an existing task completes, providing backpressure to prevent unbounded memory growth.NULL(default) preserves existing unlimited queuing behavior.Benefits
info()instead of send/recv query protocolsystem2()call to spawn a dispatcher process, no multi-step synchronization handshakedispatcher()function andR/dispatcher.R— net deletion of ~80 linesfyi @lionel- this is a significant milestone for mirai