Reduce memory usage during message encoding / serialization #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219.
This PR allocates a
nng_msgupfront and usesnng_msg_append()directly in all the internal encoding and serialization functions to avoid allocation of an intermediate object and memcpy - reducing peak memory usage.Previously, we used a
nano_bufstruct (similar to base R'smembuf). This held the serialized object before being appended in its entirety to annng_msg. This would perform amemcpy()on the object - a real one, not one that would be optimized away by the compiler.Note: we still retain the use of
nano_bufin places such as stream sends which are notnng_msgbased.FYI @lionel-