Support setAs() and setGroupGeneric() - #1909
Merged
Merged
Conversation
Both were unrecognised by object_from_call(), so a roxygen block in front of either produced an Rd file with no \usage and, for setAs(), no method alias. R-devel now NOTEs this as "Rd files without \usage". setAs() defines a method for coerce(), so it maps to an s4method object; setGroupGeneric() creates a generic, so parser_setGeneric() works as is. Fixes #1908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roxygen2 didn't recognise
setAs()orsetGroupGeneric(), so a roxygen block in front of either produced an Rd file with no\usage— which current R-devel reports asRd files without \usage.setAs()also got no method alias. Both now behave likesetMethod()andsetGeneric():Fixes #1908
🤖 Generated with Claude Code