Skip to content

fix typos #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typos #1971

wants to merge 1 commit into from

Conversation

musvaage
Copy link

@musvaage musvaage commented Apr 29, 2025

unattended to

$ grep -nr assumg vctrs
vctrs/tests/testthat/test-match.R:702:  # At the C level, our helpers assumg NA and NaN are the smallest values,
$ grep -nr errneously vctrs
vctrs/tests/testthat/test-match.R:1036:test_that("`multiple = 'error'` doesn't error errneously on the last observation", {
vctrs/tests/testthat/test-match.R:1248:test_that("`relationship` doesn't error errneously on the last observation", {
$ grep -nr presedence vctrs
vctrs/tests/testthat/test-order.R:798:test_that("first column has ordering presedence", {
$ grep -nr unsuported vctrs
vctrs/tests/testthat/test-equal.R:4:test_that("throws error for unsuported type", {
$ 

@musvaage
Copy link
Author

@JosiahParry

homogeneous lists

Have you an opinion on the following?

$ grep -nr homogenous vctrs
vctrs/src/decl/c-unchop-decl.h:16:                            enum fallback_homogeneous homogenous,
vctrs/R/type-list-of.R:1:#' `list_of` S3 class for homogenous lists
vctrs/man/list_of.Rd:9:\title{\code{list_of} S3 class for homogenous lists}
$ 

@musvaage
Copy link
Author

musvaage commented Apr 30, 2025

@MichaelChirico

Have you an explanation for the failed checks which occur likewise in other recently opened pulls?

@MichaelChirico
Copy link
Contributor

I see this in the log:

❯ checking Rd cross-references ... WARNING
  Missing link(s) in Rd file 'new_rcrd.Rd':
    ‘Record-style objects’
  
  See section 'Cross-references' in the 'Writing R Extensions' manual.
  
  Found the following Rd file(s) with Rd \link{} targets missing package
  anchors:
    new_rcrd.Rd: Record-style objects
  Please provide package anchors for all Rd \link{} targets not in the
  package itself and the base packages.

@MichaelChirico
Copy link
Contributor

Possibly, it's due to the corresponding page being marked internal?

\keyword{internal}

@musvaage
Copy link
Author

@hadley

Have you comments regarding the failed checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants