Ensure we vec_ptype_finalise() when we treat vec_ptype2() like a "common" ptype computation
#2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until after `default` has been included, then we `vec_ptype_finalize()` on the way out
DavisVaughan
changed the title
vec_ptype_finalise in matching functionvec_ptype_finalise() when we treat vec_ptype2() like a "common" ptype computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vec_ptype_finalise seems to be invoked for
vec_candlist_unchop, but not forvec_in,vec_match, andvec_locate_matches. This PR adds a step of calling vec_ptype_finalise before casting the inputs.This aims to close #2106