Fix vec_ptype2() fallback path when LHS is NULL
#2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matters now because changing `x_type` to `y_type` means that `vec_ptype2(x, x)` is now being called on `POSIXlt` in `vec_c()` and friends instead of `vec_ptype(x)`. This should not have mattered, but they returned different results (ptype kept POSIXlt, ptype2 changed to POSIXct). I've fixed this inconsistency by pushing ptype towards POSIXct as well, which feels right.
`vec_ptype2(foobar(1:3), foobar(1:3))` which returns a `<quux>`, and then `vec_ptype2(<quux>, foobar(4L))`
It would work if you register the other half of the old-style `vec_ptype2()` self-self method, but I can't figure out how to register the old-style `vec_ptype2.vctrs_implements_ptype2_true` generic, and it doesn't feel worth it to keep this.
This is what previously failed with `x_ptype` instead of `y_ptype`
It hardcodes the `tzone` to `"UTC"` rather than using `""` like we intended
Member
Author
|
There are unfortunately more revdep failures we are going to have to deal with from this Some related to POSIXlt going towards POSIXct more often. Some related to ptype2 being called more often, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2127
Closes #1981
The goal of this PR was to fix this small
x_type->y_typetypo herevctrs/src/ptype2.c
Line 71 in 29c5518
But since that is run as the very first iteration of almost every
vec_ptype_common()call (because we start the reduction withx = NULL, y = xs[[1]]), it had a huge amount of fallout of weird buggy cases that relied on this.I think pretty much every change I had to make was a net improvement. The sf commit was particularly complicated though.
One other meaningful change is that I've added
vec_ptype.POSIXlt(), which returns a correspondingPOSIXct, so thatvec_ptype_common(<POSIXlt>)andvec_ptype_common(<POSIXlt>, <POSIXlt>)consistently return aPOSIXct, which has implications forvec_c(x)andvec_c(x, x)as well (now both returnPOSIXct).Best to look at these commits one at a time.