fix(docker-compose): add extra_hosts for host access and define ac-nework#43
Merged
r-o-b-o-t-o merged 2 commits intoJul 11, 2025
Merged
Conversation
Owner
|
Exposing the host's network sounds like a security flaw, could you make it opt-in? Maybe use an environment variable like you did for the AC network |
Contributor
Author
There's not a "clean" way to do that, so the best is to use an override file, that's what we are going to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
docker-compose.ymlfile to improve development flexibility by enabling container access to the host machine and adding configuration for an additional network.Networking and development improvements:
extra_hostsconfiguration to allow the container to access the host machine, which is useful for development purposes such as accessing services like databases running on the host (docker-compose.yml).ac-networkconfiguration undernetworks, including support for a customizable network name and an option to use an external network (docker-compose.yml).