Skip to content

fix(docker-compose): add extra_hosts for host access and define ac-nework#43

Merged
r-o-b-o-t-o merged 2 commits into
r-o-b-o-t-o:masterfrom
Yehonal:chore/allow-network-rename
Jul 11, 2025
Merged

fix(docker-compose): add extra_hosts for host access and define ac-nework#43
r-o-b-o-t-o merged 2 commits into
r-o-b-o-t-o:masterfrom
Yehonal:chore/allow-network-rename

Conversation

@Yehonal

@Yehonal Yehonal commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

This pull request updates the docker-compose.yml file to improve development flexibility by enabling container access to the host machine and adding configuration for an additional network.

Networking and development improvements:

  • Added extra_hosts configuration to allow the container to access the host machine, which is useful for development purposes such as accessing services like databases running on the host (docker-compose.yml).
  • Introduced a new ac-network configuration under networks, including support for a customizable network name and an option to use an external network (docker-compose.yml).

@r-o-b-o-t-o

Copy link
Copy Markdown
Owner

Exposing the host's network sounds like a security flaw, could you make it opt-in? Maybe use an environment variable like you did for the AC network

@Yehonal

Yehonal commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

Exposing the host's network sounds like a security flaw, could you make it opt-in? Maybe use an environment variable like you did for the AC network

There's not a "clean" way to do that, so the best is to use an override file, that's what we are going to do

@r-o-b-o-t-o r-o-b-o-t-o merged commit f37189e into r-o-b-o-t-o:master Jul 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants