Allow hexadecimal colors (with opacities) and contextmenu #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivity, hoverWait, etc), expose mouseover to Shiny, dont reassign ...
…d "clearGlGroup", set active = TRUE/FALSE when hiding/showing, refactor docs
…sts for popup = FALSE
Merge branch 'fixlabels' of https://github.com/trafficonese/leafgl into fixlabels # Conflicts: # DESCRIPTION
…), use Leaflet.glify 3.3.1
… respected until now.. fix color tests, since hexcolors are not encoded to a color-matrix anymore
|
The additional arguments to But in general, I am not sure about the *Src functions. @tim-salabim Do you have any benchmarks where they are much faster? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #95 and also uses the latest Leaflet.Glify version 3.3.1.
It is now possible to use hex-colors. The hex-colors can also have different opacities (depending on a variable) so it addresses #2.
The different opacities only work for Polygons and Points. Lines do still have some bug..
The new version also allows for the creation of a contextmenu / right-clicks. addresses #79
Unfortunately it is not compatible with leaflet.extras2::contextmenu.
But with some JS knowldge one can create his own menues. I included an example with hex-colors, opacities and different contextmenues for shapes/lines and points in
/inst/examples/contextmenu.R