Prevent Rcpp from masking valid uses of Rf_error #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
Author
|
Check errors must be unrelated, because I just added a preprocessor flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
-DRCPP_NO_MASK_RF_ERRORflag to prevent Rcpp from masking valid calls toRf_error.At Rcpp, we plan to warn about this (see this issue for further discussion), and at some point stop the compilation with an error message, forcing the maintainers to take action. For valid uses of
Rf_error, like in this package, we will provide this opt-out switch. Therefore, we kindly ask you to apply this patch and send an update to CRAN at your earliest convenience.