Skip to content

One possible fix to work around the version of abseil in current debian testing#295

Draft
paleolimbot wants to merge 2 commits intomainfrom
fix-files
Draft

One possible fix to work around the version of abseil in current debian testing#295
paleolimbot wants to merge 2 commits intomainfrom
fix-files

Conversation

@paleolimbot
Copy link
Collaborator

(Just keeping track of this on a branch for now and also looking into another fix)

For #293.

@paleolimbot
Copy link
Collaborator Author

In its current form, this doesn't compile on Windows because:

      |   ^
s2/s2boolean_operation.cc: In member function 'bool S2BooleanOperation::Impl::CrossingProcessor::is_degenerate(S2BooleanOperation::Impl::ShapeEdgeId) const':
s2/s2boolean_operation.cc:1215:32: error: 'const class std::unordered_map<s2shapeutil::ShapeEdgeId, bool>' has no member named 'contains'
 1215 |     return is_degenerate_hole_.contains(a_id);
      |                                ^~~~~~~~
make: *** [C:/R/etc/x64/Makeconf:294: s2/s2boolean_operation.o] Error 1
ERROR: compilation failed for package 's2'
* removing 'D:/a/s2/s2/check/s2.Rcheck/s2'\

I think contains is C++20+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments