-
Notifications
You must be signed in to change notification settings - Fork 0
Default scaffolding with savvy::savvy_init().
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jibarozzo i have not yet had the chance to dig into the differences between extendr and savvy I will dig into that early next week, but in the mean time could you please summarize what factors lead you to decide on this approach? |
Co-authored-by: Jackson Hoffart <[email protected]>
Initial differencesThe scaffolding for both is about the same. The main difference I see is in error handling. Error handling with Another main difference I see are the dependencies. Caveats
Some design ideas from the author (summarized here)Final thoughtsThe idea with |
jdhoffa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is CI failure on R CMD check for ubuntu and windows (however only warnings) but not sure how much that matters.
Approving
|
I checked the warning a little bit closer. For the
For now, I'll merge and open an issue. |
Addressing issue #5. Used the defaults from
savvy::savvy_init()to create Rust scaffolding inside R package. Depending on what we decide withextendrorsavvywe can merge this branch or create another with the default scaffolding fromextendr. They provide similar structure and documentation.