downloadFileContent(): Follow URL redirects in Node [#585]

[HenrikBengtsson]

No description provided.

[dirkschumacher]

LGTM, but I am not a maintainer 😅. There are some tests for webr-workers, so maybe there is a way to test this feature.

[HenrikBengtsson]

The GA build-webr checks produced:

/__w/webr/webr/src/webR/webr-worker.ts
Error:   595:72  error  Type number trivially inferred from a number literal, remove type annotation  @typescript-eslint/no-inferrable-types

I address that in commit 1f2011e. @georgestagg , could please trigger a rerun?

[georgestagg]

Yeah, the linter is configured to be quite picky…

You may be able to check it locally quicker by cd-ing into src and running make lint

[HenrikBengtsson]

You may be able to check it locally quicker by cd-ing into src and running make lint

Thx - worked like a charm. Confirming I could reproduce the lint error, which is gone in the most recent commit.

[georgestagg]

LGTM!

If we wanted, we could add a test for download.file() in the same place as we already have a couple of tests that depend on networking here.

Happy to merge without, but it's an option if you'd like to add it. We'd need to test downloading a file from with a reasonable URL that will always be consistent and available.

[HenrikBengtsson]

I've added direct tests of utils::download.file() with and without URL redirects.

I also added a test of <shim>::install.packages() from R-universe, which (currently) involves a URL redirect.

[HenrikBengtsson]

Forgot to say, I finally got the build environment up so I could run:

./configure && make 
make check

which passes with all OK.