⚡ Optimize instruction prefix extraction loops

[r0ny123]

💡 What:

• Added a static, class-level _PREFIXES set to cache prefix lookups in smda/intel/IntelInstructionEscaper.py.
• Replaced the inline list comprehensions [ins_bytes[i: i+2] ...] in getByteWithoutPrefixes and escapeToOpcodeOnly with sequential string slicing directly.

🎯 Why:

• The prior code allocated a new list and a set of prefixes for every single instruction processing iteration, generating significant overhead inside what should be a fast utility function. This caused unnecessary memory allocations.

📊 Measured Improvement:

• Micro-benchmarks running getByteWithoutPrefixes and escapeToOpcodeOnly over 100k instructions showed approx a 2x overall runtime improvement:
  • getByteWithoutPrefixes: 0.99s -> 0.41s
  • escapeToOpcodeOnly: 1.38s -> 0.74s
• Both functional equivalence and test suites remain green.

---

PR created automatically by Jules for task 14142918817124732542 started by @r0ny123

---

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

[gemini-code-assist]

Code Review

This pull request refactors the prefix handling in IntelInstructionEscaper.py by introducing a centralized _PREFIXES set and utilizing slicing instead of manual string concatenation for better efficiency. A review comment suggests using a more idiomatic Python approach with a generator expression and next() to determine the prefix length, which would simplify the logic and avoid the for...else construct.

[r0ny123]

Addressed the review feedback in fc73014:

• Replaced the for...else loop in escapeToOpcodeOnly with the suggested next() + generator-expression idiom.
• Applied the same idiom to getByteWithoutPrefixes for consistency between the two prefix-stripping helpers.
• Bound IntelInstructionEscaper._PREFIXES to a local prefixes name in both functions to avoid the repeated class attribute lookup inside the generator on each step.

/gemini review

---

Generated by Claude Code

[gemini-code-assist]

Code Review

This pull request refactors the prefix handling logic in IntelInstructionEscaper.py by introducing a _PREFIXES constant and replacing manual loops with more concise generator expressions in escapeToOpcodeOnly and getByteWithoutPrefixes. The review feedback suggests moving the new constant to the top of the class to maintain consistency with existing code and extracting the duplicated prefix length calculation into a shared helper method to adhere to DRY principles.

[r0ny123]

Addressed both new review comments in 8344a60:

• Moved _PREFIXES up next to the other class-level constants (after _control_registers) for consistency with the existing structure.
• Extracted the duplicated prefix-length scan out of escapeToOpcodeOnly and getByteWithoutPrefixes into a shared _getPrefixLen(ins_bytes) static helper (DRY).

/gemini review

---

Generated by Claude Code

[gemini-code-assist]

Code Review

This pull request refactors the prefix handling in IntelInstructionEscaper.py by introducing a centralized _PREFIXES set and a helper method _getPrefixLen. This change eliminates redundant logic in escapeToOpcodeOnly and getByteWithoutPrefixes. The review feedback suggests converting _getPrefixLen from a static method to a class method to avoid hardcoding the class name and improve flexibility for potential subclassing.