fix(dalvik): recover try-catch exception edges and mark Makefile targets as phony#44
Conversation
📝 WalkthroughWalkthroughThis PR enhances Dalvik opcode metadata to mark field-access and integer division operations as capable of throwing exceptions. A post-registration helper updates opcode specs, and two new unit tests verify the metadata reaches the disassembler's exception edge analysis. The Makefile is updated to declare additional build targets as phony. ChangesThrowable Opcode Metadata and Exception Edge Analysis
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Code Review
This pull request introduces changes to identify throwable Dalvik opcodes, marking static field access and integer division/remainder operations as throwable, and adds corresponding unit tests to verify exception edge generation. A review comment suggests improving the robustness of the _mark_can_throw helper function to correctly handle potential duplicate mnemonics and optimize dictionary iteration.
Summary by CodeRabbit
Bug Fixes
Tests
Chores