Fix types of find in sdk client and update dependencies #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
Current Situation
The typing of
selectin the following functionsthat specified an array
K extends (keyof C['collections'][T])[]was not correct as input forqueryString.stringify(...)(qs). As a result, the function only returned the ID ifselectwas used in the form of an array.The resulting query looked like this
...datasets?depth=2&select[0]=slug&select[1]=titleFix
Types are changed to a
Partialobject and boolean values.The resulting query
...datasets?depth=2&select[slug]=true&select[title]=trueI think this is the easiest fix, otherwise we would have to pull out the select array from
toQsand transform it to an object.But if this is more appreciated, I can also change the PR to that way.