fix(tv): don't auto-add ?ch= on load (only after the viewer tunes) - #279
Merged
Conversation
The TV channel writeback effect ran for the initial auto-selected channel, so a fresh visit to the homepage immediately rewrote the URL to `?ch=<propNumber>`. Gate the writeback behind a ref that flips only when the viewer actually tunes a channel. A clean load now keeps a clean URL; a `?ch=` deep link still selects on load and is preserved.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: landing on the homepage auto-redirected the URL to
?ch=<propNumber>(e.g.?ch=110) without any interaction.Cause: the channel→URL writeback
useEffectfired for the initial auto-selected channel, not just on a real channel change.Fix: gate the writeback behind a
userHasTunedRefthat flips only insidetuneTo(the sole user-drivensetIndexpath). Fresh load ⇒ clean URL; a?ch=deep link still selects on load (read-once effect) and stays until the viewer changes channels.tsc+eslintclean.