-
-
Notifications
You must be signed in to change notification settings - Fork 4
Upgrade games and social cogs to use DekuDeals as a data source #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Proposed migration steps:
Edit 2026-01-09 to add item 4 |
|
Also: the migration is not perfect, but it should be pretty decent for most mainstream games (that weren't NSO things): Here's an example of a poor-case migration with some stuff from NSO, mostly: |
|
I have replaced fuzzywuzzy with rapidfuzz, a more performant drop-in replacement for fuzzywuzzy. I have auto replaced our old average of 4 methods search logic with WRatio from RapidFuzzy/fuzzywuzzy, which does a similar average of methods. The immense performance improvement from these changes has allowed me to re-add autocomplete for game searching, which mitigates any search quality flaws with using WRatio. |
|
Here is a new example of migration substitutions. Noting that most imperfect matches are due to non-Switch games available on NSO, which DekuDeals does not list like GiantBomb did. Other differences in matches appear to be due to how GiantBomb grouped re-released into one game, or Pokemon variant games to the same game.
|
MattBSG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes tested and appear well made. Looks good :)
Pull request template
Use this template for all contributions made for the repository.
Please indicate all that apply with a checkmark. To make a check, convert brackets below to
[x].Describe what your pull request does
Upgrade games and social cogs to use DekuDeals as a data source