Skip to content

Add support for custom Service labels via spec.service.labels #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EladAviczer
Copy link

@EladAviczer EladAviczer commented Apr 22, 2025

This closes #1821

Summary Of Changes

This PR introduces support for applying custom labels to the Service created by the RabbitmqCluster resource.
in the practicesuggested by the issue opener spec.service.labels

Additional Context

Local Testing

unit and integration tests succeeded.
Deployed to local cluster using the makefile.

Sample usage

apiVersion: rabbitmq.com/v1beta1
kind: RabbitmqCluster
metadata:
  name: example
spec:
  replicas: 1
  service:
    labels:
      foo: "bar"

@EladAviczer EladAviczer changed the title Added to types and controller ran tests pushing to work on another te… Add support for custom Service labels via spec.service.labels Apr 22, 2025
@EladAviczer
Copy link
Author

For the reviewer: please consider moving the if clause further down in the function for aesthetic reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding labels to spec.service
1 participant