Recover integration test for owner reference #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of abc5737, we chopped the test related to owner references. The system tests verify that objects are garbage collected, and that proves that an owner reference is set. However, the system tests do not explicitly verify that the object does not block the owner deletion. This is required for OpenShift compatibility. This commit recovers the owner reference test for User generated secret.
Now it is possible to shell eval the output of this target, like so: ``` eval "$(gmake kubebuilder-assets)" ``` This is helpful to run `ginkgo` commands directly, without Make
This can cause test pollution with other suites that do not expect to set user limits, and consequently don't prepare the fake HTTP client to respond to user limit creation.
Zerpet
force-pushed
the
tweak-owner-reference-behaviour
branch
from
e579d1c to
ce4b4d6
Compare
|
ce4b4d6 should fix the last remains of flakes in the integration tests. I had done this for vhosts, I overlooked user limits in my previous PR 😢 |
MirahImage
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
As part of abc5737, we chopped the test related to owner references. The system tests verify that objects are garbage collected, and that proves that an owner reference is set. However, the system tests do not explicitly verify that the object does not block the owner deletion. This is required for OpenShift compatibility.
This PR recovers the owner reference test for User generated secret.