-
Notifications
You must be signed in to change notification settings - Fork 8
Add DelayedQueueSpecification for Tanzu delayed queues #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fd41e39
1840244
e8c63c1
5c53f77
a5e1c3a
bbcc747
3524aeb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,199 @@ | ||||||||||
| // RabbitMQ AMQP 1.0 Go Client: https://github.com/rabbitmq/rabbitmq-amqp-go-client | ||||||||||
| // RabbitMQ AMQP 1.0 documentation: https://www.rabbitmq.com/docs/amqp | ||||||||||
| // This example mirrors getting_started but declares a delayed queue via DelayedQueueSpecification | ||||||||||
| // (RabbitMQ queue type "delayed"). Delayed queues are available on Tanzu RabbitMQ 4.x+; see: | ||||||||||
| // https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-rabbitmq-on-kubernetes/4-2/tanzu-rabbitmq-kubernetes/delayed-queues.html | ||||||||||
|
Comment on lines
+4
to
+5
|
||||||||||
| // (RabbitMQ queue type "delayed"). Delayed queues are available on Tanzu RabbitMQ 4.x+; see: | |
| // https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-rabbitmq-on-kubernetes/4-2/tanzu-rabbitmq-kubernetes/delayed-queues.html | |
| // (RabbitMQ queue type "delayed"). Delayed queues are available on Tanzu RabbitMQ 4.3+; see: | |
| // https://techdocs.broadcom.com/us/en/vmware-tanzu/data-solutions/tanzu-rabbitmq-on-kubernetes/4-3/tanzu-rabbitmq-kubernetes/delayed-queues.html |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -225,10 +225,12 @@ var _ = Describe("Recovery connection test", func() { | |
| Entry("Classic queue", Classic, true, true, map[string]any{}), | ||
| Entry("Stream queue", Stream, false, false, map[string]any{}), | ||
| //Entry("JMS queue", Jms, false, false, map[string]any{}), | ||
| //Entry("Delayed queue", Delayed, false, false, map[string]any{}), | ||
| Entry("Quorum queue with arguments", Quorum, false, false, map[string]any{"x-max-length-bytes": 1000}), | ||
| Entry("Classic queue with arguments", Classic, true, true, map[string]any{"x-max-length-bytes": 1000}), | ||
| Entry("Stream queue with arguments", Stream, false, false, map[string]any{"x-max-length-bytes": 1000}), | ||
| //Entry("JMS queue with arguments", Jms, false, false, map[string]any{"x-max-length-bytes": 1000}), | ||
| Entry("Delayed queue with arguments", Delayed, false, false, map[string]any{"x-max-length-bytes": 1000}), | ||
|
Comment on lines
225
to
+233
|
||
| ) | ||
|
|
||
| DescribeTable("Exchange record returns the expected exchange specification", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Delayed queue entry says Tanzu RabbitMQ 4.x, while other documentation in this PR (AGENTS.md and the runtime validation error) says 4.3+. Please make the version requirement consistent across docs and code so users don’t get conflicting guidance.