fix: multiconnection loop not breaking after successfull connect - #120
Conversation
|
hi @Chr1s70ph Thank you for contributing to this client. Recently (a month ago), our company made some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR. The process is explained here in this repo README: https://github.com/rabbitmq/cla Would you review and sign this CLA? |
I have read the README and have sent an email requesting the CLA so I can sign it. |
|
I have since received the CLA and signed it. Is there anything left for me to do? |
|
Confirmed CLA is signed, thank you for contributing! |
|
@Chr1s70ph, since you are there. Can you please add a test for that? |
Note: AI was used to generate those tests
|
@Gsantomaggio I added some tests (with the assistance of AI), I hope they fit your requirements :) |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
Thank you @Chr1s70ph |
BlockingConnection._inititerates over every URL inurlswithout stopping after a successful connect.If the last node from the
urlslist was down, both inital connect and auto-reconnect failed even when other nodes were healthy.