Skip to content

fix: multiconnection loop not breaking after successfull connect - #120

Merged
Gsantomaggio merged 3 commits into
rabbitmq:mainfrom
Chr1s70ph:patch-1
Jun 23, 2026
Merged

fix: multiconnection loop not breaking after successfull connect#120
Gsantomaggio merged 3 commits into
rabbitmq:mainfrom
Chr1s70ph:patch-1

Conversation

@Chr1s70ph

Copy link
Copy Markdown
Contributor

BlockingConnection._init iterates over every URL in urls without stopping after a successful connect.

If the last node from the urls list was down, both inital connect and auto-reconnect failed even when other nodes were healthy.

@Gsantomaggio

Copy link
Copy Markdown
Member

hi @Chr1s70ph

Thank you for contributing to this client. Recently (a month ago), our company made some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR.

The process is explained here in this repo README: https://github.com/rabbitmq/cla

Would you review and sign this CLA?

@Chr1s70ph

Copy link
Copy Markdown
Contributor Author

hi @Chr1s70ph

Thank you for contributing to this client. Recently (a month ago), our company made some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR.

The process is explained here in this repo README: https://github.com/rabbitmq/cla

Would you review and sign this CLA?

I have read the README and have sent an email requesting the CLA so I can sign it.
I'll keep you updated!

@Gsantomaggio Gsantomaggio added this to the 1.0 milestone Jun 22, 2026
@Gsantomaggio Gsantomaggio added bug Something isn't working bug-fix The PR fixes a bug and removed bug Something isn't working labels Jun 22, 2026
@Chr1s70ph

Copy link
Copy Markdown
Contributor Author

I have since received the CLA and signed it.

Is there anything left for me to do?

@Zerpet

Zerpet commented Jun 22, 2026

Copy link
Copy Markdown
Member

Confirmed CLA is signed, thank you for contributing!

@Gsantomaggio

Copy link
Copy Markdown
Member

@Chr1s70ph, since you are there. Can you please add a test for that?

@Gsantomaggio Gsantomaggio self-assigned this Jun 22, 2026
Note: AI was used to generate those tests
@Chr1s70ph

Copy link
Copy Markdown
Contributor Author

@Gsantomaggio I added some tests (with the assistance of AI), I hope they fit your requirements :)

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio
Gsantomaggio merged commit b11ea59 into rabbitmq:main Jun 23, 2026
1 check passed
@Gsantomaggio

Copy link
Copy Markdown
Member

Thank you @Chr1s70ph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix The PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants