Add fixture-driven validation tests for the AMQP 1.0 reader - #125
Merged
Conversation
Port the 004_amqp10_validation fixture corpus into tests/unit/resources and add one decode test per fixture (empty message, vbin8/vbin32 body size boundary, large ApplicationProperties maps, Properties+map combos, UUID/unicode fields, nil-amid-mixed-types, exact-match golden message, and rejection of a message with conflicting body sections), mirroring rabbitmq-stream-dotnet-client's Tests/Amqp10Tests.cs approach. Fix a decoder bug these fixtures surfaced: Decoder._read_compound forced the cursor to start+declared_size after parsing a list/map/array instead of trusting where parsing its self-describing elements actually landed, silently truncating a trailing field whenever a producer's declared size was wrong (message_from_version_1_0_0.amqp undercounts by exactly the count field's width). The declared size is now only used as an upfront overrun guard. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Gsantomaggio
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the 004_amqp10_validation fixture corpus into tests/unit/resources and add one decode test per fixture (empty message, vbin8/vbin32 body size boundary, large ApplicationProperties maps, Properties+map combos, UUID/unicode fields, nil-amid-mixed-types, exact-match golden message, and rejection of a message with conflicting body sections), mirroring rabbitmq-stream-dotnet-client's Tests/Amqp10Tests.cs approach.
Fix a decoder bug these fixtures surfaced: Decoder._read_compound forced the cursor to start+declared_size after parsing a list/map/array instead of trusting where parsing its self-describing elements actually landed, silently truncating a trailing field whenever a producer's declared size was wrong (message_from_version_1_0_0.amqp undercounts by exactly the count field's width). The declared size is now only used as an upfront overrun guard.