-
Notifications
You must be signed in to change notification settings - Fork 5
Consumer implementation #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <[email protected]>
* connection layer implementation * WIP * implementing Declare Exchange/Queue * test for gabriele * body encodiding Signed-off-by: Gabriele Santomaggio <[email protected]> * adding basic tests * implementing bind * adding user-defined exception * Adding debugging info * publisher implementation * adding publisher basic test * improve help_address utility functions * modify example * integrate qpid-proton lib * implementing purge operation * improving url helper * cleaning up qpid unecessary folders and files * some improvements * implementing queue_info * fixing queue arguments management * better management of arguments * improved arguments management during declare_queue * adding purge test * adding fixtures in tests * adding a publisher test * removing useless queue_type parameter * removing receiver from publisher --------- Signed-off-by: Gabriele Santomaggio <[email protected]> Co-authored-by: DanielePalaia <daniele985@@gmail.com> Co-authored-by: Gabriele Santomaggio <[email protected]>
2454544
to
a1cc43c
Compare
3359ebb
to
22410c2
Compare
Hey @Gsantomaggio @lukebakken I think we can start reviewing this. |
22410c2
to
cb03ba6
Compare
cb03ba6
to
0107ce9
Compare
0107ce9
to
2983576
Compare
add documentation Signed-off-by: Gabriele Santomaggio <[email protected]>
@DanielePalaia in case of requeue or discard with annotations you need to validate the keys like: |
7c86c49
to
c944595
Compare
c944595
to
088eefd
Compare
Gsantomaggio
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #12
Consumer side implementation.
The qpid-proton implementation already implements the receiving of messages through callbacks, so I kept this implementation.
The user can create a class which inherits from qpid-proton MessagingHandler (This symbol is now exported in our rabbitmq-amqp-python-client project) to manage the message consumed through the callback on_message of this class.
An utility class MessageAck has been implemented in order to manage the Acks to send back to the server (accept, discard, requeue, discard_with_annotations, requeue_with_annotations)
The example has been updated in ./examples/getting_started/main.py