Skip to content

Fix #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix #58

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 36 additions & 66 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ readme = "README.md"
[tool.poetry.dependencies]
python = "^3.9"
python-qpid-proton = "^0.39.0"
jwt = "^1.3.1"
pyjwt = "^2.10.1"

[tool.poetry.group.dev.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion rabbitmq_amqp_python_client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def _create_connection(self) -> None:
mechs = None

if self._oauth2_options is not None:
user = ""
user = "no"
password = self._oauth2_options.token
mechs = "PLAIN"
print("password, mechs: " + user + " " + password)
Expand Down
3 changes: 2 additions & 1 deletion rabbitmq_amqp_python_client/qpid/proton/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,8 @@ def __init__(
)

except ConnectionException:
self.conn.close()
if self.conn is not None:
self.conn.close()
if attempt == len(urls):
raise
continue
Expand Down
8 changes: 4 additions & 4 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ def environment_auth(pytestconfig):
uri="amqp://localhost:5672",
oauth2_options=OAuth2Options(token=token_string),
)
try:
yield environment
# try:
return environment

finally:
environment.close()
# finally:
# environment.close()


@pytest.fixture()
Expand Down
Loading