Implement Direct Reply To Feature #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the Direct Reply-To feature for the RabbitMQ AMQP Python client, allowing clients to use server-generated temporary queues for RPC-style request/response patterns. The implementation adds a new DirectReplyToConsumerOptions class and supporting infrastructure to create dynamic receivers with RabbitMQ 4.2.0+ servers.
Key Changes:
- Added
DirectReplyToConsumerOptionsclass with RabbitMQ 4.2.0 version validation - Implemented dynamic receiver creation with volatile queue capabilities
- Updated dependency to python-qpid-proton 0.40.0
- Added test coverage and example implementation
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
rabbitmq_amqp_python_client/entities.py |
Adds DirectReplyToConsumerOptions class with validation and direct_reply_to() method |
rabbitmq_amqp_python_client/consumer.py |
Implements Direct Reply-To logic in consumer creation and adds get_queue_address() method |
rabbitmq_amqp_python_client/connection.py |
Updates address validation to allow empty destinations for DirectReplyToConsumerOptions |
rabbitmq_amqp_python_client/options.py |
Adds DynamicReceiverOption to configure dynamic receivers with volatile queue capabilities |
rabbitmq_amqp_python_client/qpid/proton/_utils.py |
Adds create_dynamic_receiver() helper method |
rabbitmq_amqp_python_client/__init__.py |
Exports new DirectReplyToConsumerOptions class |
rabbitmq_amqp_python_client/publisher.py |
Style improvement: simplifies boolean comparison |
pyproject.toml |
Updates python-qpid-proton dependency to 0.40.0 |
poetry.lock |
Lock file update reflecting new dependency versions |
tests/direct_reply_to/test_direct_reply.py |
Adds basic test for Direct Reply-To queue address generation |
examples/direct_reply_queue/direct_reply_to.py |
Provides example demonstrating Direct Reply-To usage pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@Gsantomaggio I've opened a new pull request, #88, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
…mqp-python-client into feat/direct-reply-to
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
This PR implements the Direct Reply-To feature for the RabbitMQ AMQP Python client, allowing clients to use server-generated temporary queues for RPC-style request/response patterns. The implementation adds a new DirectReplyToConsumerOptions class and supporting infrastructure to create dynamic receivers with RabbitMQ 4.2.0+ servers.
Key Changes: