Skip to content

Remove StackTrace from EventSource Message #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

eerhardt
Copy link
Contributor

@eerhardt eerhardt commented Feb 9, 2024

Proposed Changes

When logging connection exception information to the EventSoruce we are putting the full exception ToString in the Message which clutters it to the users.

Instead, just put the Exception.Message in the EventSource event message. The full exception information comes in the details of the EventSource event.

Fix #1493

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

cc @lukebakken

When logging connection exception information to the EventSoruce we are putting the full exception ToString in the Message which clutters it to the users.

Instead, just put the Exception.Message in the EventSource event message. The full exception information comes in the details of the EventSource event.

Fix rabbitmq#1493
@lukebakken lukebakken self-assigned this Feb 9, 2024
@lukebakken lukebakken self-requested a review February 9, 2024 20:45
@lukebakken lukebakken added this to the 6.9.0 milestone Feb 9, 2024
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken merged commit 55010ab into rabbitmq:6.x Feb 12, 2024
lukebakken added a commit that referenced this pull request Feb 12, 2024
Fixes #1493 by porting 55010ab to `main`
lukebakken added a commit that referenced this pull request Feb 12, 2024
Fixes #1493 by porting 55010ab to `main`
@eerhardt eerhardt deleted the UpdateConnectionFailureLog branch December 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants