Skip to content

Backport #1616 to 6.x #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Backport #1616 to 6.x #1618

merged 1 commit into from
Jul 3, 2024

Conversation

Saibamen
Copy link

@Saibamen Saibamen commented Jun 27, 2024

Backport #1616 to 6.x

Fixes #1617

@pivotal-cla
Copy link

@Saibamen Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@Saibamen Saibamen mentioned this pull request Jun 27, 2024
@pivotal-cla
Copy link

@Saibamen Thank you for signing the Contributor License Agreement!

@Saibamen Saibamen closed this Jun 27, 2024
@Saibamen Saibamen reopened this Jun 27, 2024
@Saibamen
Copy link
Author

Sorry for mess. GitHub does not allow to commit multiple files via web browser editor or commit multiple PR suggestion in one commit.

@lukebakken
Copy link
Collaborator

@Saibamen no worries, I cleaned it up.

@lukebakken lukebakken self-requested a review June 27, 2024 23:55
@lukebakken lukebakken self-assigned this Jun 27, 2024
@lukebakken lukebakken added this to the 6.9.0 milestone Jun 27, 2024
@Saibamen
Copy link
Author

TestQueueRecoveryWithDlxArgument_RabbitMQUsers_hk5pJ4cKF0c is still missing, but I'm not familiar with NUnit and test folders and helpers was refactored in master branch.

Fixes rabbitmq#1617

Update RecordedConsumer.cs
Update RecordedExchange.cs
Update RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs
Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs
Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs
Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs
Update `TestRecoveringConsumerHandlerOnConnection_EventArgumentsArePassedDown`
Update projects/Unit/TestConnectionRecovery.cs

Port test from `main`
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukebakken lukebakken merged commit 0e778f4 into rabbitmq:6.x Jul 3, 2024
1 check passed
@Saibamen Saibamen deleted the patch-1 branch July 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants