Skip to content

Added 'unlimited' config setting for peer_discovery_retry_limit (backport #13673) (backport #13675) #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 3, 2025

Proposed Changes

The peer discovery code can handle the Retry value to be either a non-negative integer, or the atom 'unlimited'.

-spec discovery_retries(Backend) -> {Retries, RetryDelay} when
      Backend :: backend(),
      Retries :: non_neg_integer() | unlimited,
      RetryDelay :: non_neg_integer().

But the cuttlefish config only allows non neg integers. I suggest we also allow the value 'unlimited' to be set through config.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.


This is an automatic backport of pull request #13673 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #13675 done by [Mergify](https://mergify.com).

(cherry picked from commit b7c4f66)
(cherry picked from commit 668178d)
@michaelklishin michaelklishin added this to the 4.0.8 milestone Apr 3, 2025
@michaelklishin michaelklishin merged commit dd920b6 into v4.0.x Apr 3, 2025
269 of 270 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.0.x/pr-13675 branch April 3, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants