Remove dead timer code in rabbit_fifo_client
#15210
Merged
+3
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case
resends_lost_commandofrabbit_fifo_int_SUITEsucceeded without testing what it is supposed to test.That's because the mock used the wrong arity.
Applying the following diff
made the test case then fail with:
The timer was never actually scheduled in
rabbit_fifo_client. This commit therefore removes all the dead code.Note that
resend_all_pending/1is nowadays executed upon leader changes.nodeupin the queue proc also causesresend_all_pending/1to be executed even if the leader didn't change.