Skip to content

Conversation

@majialoong
Copy link
Contributor

Proposed Changes

This PR fixes two error log calls in rabbit_quorum_queue that used a ~tp format placeholder but did not provide any formatting arguments.

Types of Changes

  • Bug fix (non-breaking change)

Checklist

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

This is a small, localized fix: keep the existing log message, only add the missing argument lists ([RaLeader] / [RaNode]) to match the ~tp placeholder.

@michaelklishin
Copy link
Collaborator

@majialoong thanks. Do I understand it correctly that a CLA signing request yesterday was from you?

@michaelklishin michaelklishin added this to the 4.3.0 milestone Jan 5, 2026
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this issue comes from commit e408c9e and does not apply beyond v4.2.x because, well, that commit was introduced in the 4.2.0 cycle.

@michaelklishin michaelklishin merged commit 9231fb0 into rabbitmq:main Jan 5, 2026
574 of 577 checks passed
michaelklishin added a commit that referenced this pull request Jan 5, 2026
Quorum queues: fix error logging during node drain (backport #15212)
@majialoong
Copy link
Contributor Author

@majialoong thanks. Do I understand it correctly that a CLA signing request yesterday was from you?

@michaelklishin Thanks for the review! Yes, that was me — the CLA is now signed and completed.

@majialoong majialoong deleted the fix_quorum_error_log branch January 6, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants